Skip to content

feat: soundboard forward port #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

feat: soundboard forward port #10859

merged 2 commits into from
May 9, 2025

Conversation

sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented Apr 27, 2025 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Forwardports things from:

Also fixes emojiId and emojiName still being used in equals even when they don't exist anymore (changed in 7b3cfe4 (#10590))

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza added this to the discord.js 15.0.0 milestone Apr 27, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 7:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 9, 2025 7:39am

@sdanialraza sdanialraza force-pushed the feat/soundboard-forward-port branch 2 times, most recently from 217b8ae to c64b87a Compare May 2, 2025 23:53
@sdanialraza sdanialraza force-pushed the feat/soundboard-forward-port branch from c64b87a to 5fc4606 Compare May 7, 2025 11:30
@sdanialraza sdanialraza marked this pull request as ready for review May 7, 2025 11:33
@sdanialraza sdanialraza requested a review from a team as a code owner May 7, 2025 11:33
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js May 9, 2025
@kodiakhq kodiakhq bot merged commit c4cd6ea into main May 9, 2025
8 checks passed
@kodiakhq kodiakhq bot deleted the feat/soundboard-forward-port branch May 9, 2025 07:43
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sdanialraza @vladfrangu @didinele @Jiralite